Imports Quickie

[Pace]

Hi All,

Im sooo falling in love with VB and programming in general... I was wondering if anyone could help me tidy up this code a bit, and I could well learn a new trick along the way... IE Imports.

Please can you help?

[SIZE=2][COLOR=#0000ff]Public[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Class[/COLOR][/SIZE][SIZE=2] Form1
[/SIZE][SIZE=2][COLOR=#0000ff]Inherits[/COLOR][/SIZE][SIZE=2] System.Windows.Forms.Form[/SIZE]
 
[SIZE=2]GENERATED CODE[/SIZE]
[SIZE=2]
[/SIZE][SIZE=2][COLOR=#0000ff]Private[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Sub[/COLOR][/SIZE][SIZE=2] Button2_Click([/SIZE][SIZE=2][COLOR=#0000ff]ByVal[/COLOR][/SIZE][SIZE=2] sender [/SIZE][SIZE=2][COLOR=#0000ff]As[/COLOR][/SIZE][SIZE=2] System.Object, [/SIZE][SIZE=2][COLOR=#0000ff]ByVal[/COLOR][/SIZE][SIZE=2] e [/SIZE][SIZE=2][COLOR=#0000ff]As[/COLOR][/SIZE][SIZE=2] System.EventArgs) [/SIZE][SIZE=2][COLOR=#0000ff]Handles[/COLOR][/SIZE][SIZE=2] Button2.Click
[/SIZE][SIZE=2][COLOR=#0000ff]End
[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]End[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Sub
[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Private[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Sub[/COLOR][/SIZE][SIZE=2] MenuItem2_Click([/SIZE][SIZE=2][COLOR=#0000ff]ByVal[/COLOR][/SIZE][SIZE=2] sender [/SIZE][SIZE=2][COLOR=#0000ff]As[/COLOR][/SIZE][SIZE=2] System.Object, [/SIZE][SIZE=2][COLOR=#0000ff]ByVal[/COLOR][/SIZE][SIZE=2] e [/SIZE][SIZE=2][COLOR=#0000ff]As[/COLOR][/SIZE][SIZE=2] System.EventArgs) [/SIZE][SIZE=2][COLOR=#0000ff]Handles[/COLOR][/SIZE][SIZE=2] MenuItem2.Click
[/SIZE][SIZE=2][COLOR=#0000ff]Dim[/COLOR][/SIZE][SIZE=2] StreamDisplay [/SIZE][SIZE=2][COLOR=#0000ff]As[/COLOR][/SIZE][SIZE=2] System.IO.StreamReader
[/SIZE][SIZE=2][COLOR=#0000ff]Dim[/COLOR][/SIZE][SIZE=2] FilePath [/SIZE][SIZE=2][COLOR=#0000ff]As[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]String
[/COLOR][/SIZE][SIZE=2]OpenFileDialog1.Filter = "Text File (*.txt)|*.TXT"
OpenFileDialog1.ShowDialog()
[/SIZE][SIZE=2][COLOR=#0000ff]If[/COLOR][/SIZE][SIZE=2] OpenFileDialog1.FileName <> "" [/SIZE][SIZE=2][COLOR=#0000ff]Then
[/COLOR][/SIZE][SIZE=2]FilePath = OpenFileDialog1.FileName
StreamDisplay = [/SIZE][SIZE=2][COLOR=#0000ff]New[/COLOR][/SIZE][SIZE=2] System.IO.StreamReader(FilePath)
txtInfo.Text = StreamDisplay.ReadToEnd
StreamDisplay.Close()
txtInfo.Select(0, 0)
[/SIZE][SIZE=2][COLOR=#0000ff]End[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]If
[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]End[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Sub
End[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff]Class
[/COLOR][/SIZE]

Woot im loving this

 

[mjb3030]

The only thing I would change is I would use

txtInfo.Focus()

instead of

txtInfo.Select(0,0)

Otherwise, it looks great.

 

[Pace]

Hey Thanks MJB thats a good suggestion

Can you show me how I can import the SYSTEM.IO.STREAMREADER namespace into my app?

I think its Imports System.IO near the top of my declarations, but I cant quite seem to get it in the right place for it to fit :S

edit; mis spelt STREAM :doh!:

 

[Dirty Howi]

it goes above public class form1

 

[JuggaloBrotha]

Imports System.IO

Public Class Form1
  Inherits System.Windows.Forms.Form
 
   "GENERATED CODE"

  PrivateSub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click
    Me.Close
  End Sub

  Private Sub MenuItem2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MenuItem2.Click
    OpenFileDialog1.Filter = "Text File (*.txt)|*.TXT"
    If OpenFileDialog1.ShowDialog() <> DialogResult.Cancel Then
      Dim StreamDisplay As New StreamReader(OpenFileDialog1.FileName)
      txtInfo.Text = StreamDisplay.ReadToEnd
      StreamDisplay.Close()
      txtInfo.Focus()
    End If
  End Sub
End Class

is my suggestion, it checks to see if the user clicks cancel in the dialog (if they click ok/open or whatever then a valid file has been selected)