Reply to thread

Message

[QUOTE="jmcilhinney, post: 186154, member: 641"]
You have declared a function that returns a data reader but your code doesn't actually return one. One option would be to not close the connection and open your data reader with the appropriate [ICODE]CommandBehavior[/ICODE] so that the connection is closed when the reader is closed. You then rely on the consumer to use and close the reader, e.g.
[CODE=vbnet]Public Function GetDataReader(query As String) As SqlDataReader
    Dim connection As New SqlConnection("connection string here")
    Dim command As New SqlCommand(query, connection)

connection.Open()

Return command.ExecuteReader(CommandBehavior.CloseConnection)
End Function[/CODE]
and then:
[CODE=vbnet]Using reader = GetDataReader("SELECT * FROM Table1")
    While reader.Read()
        '...
    End While
End Using[/CODE]
Alternatively, you can return a [ICODE]DataTable[/ICODE] instead:
[CODE=vbnet]Public Function GetDataTable(query As String) As DataTable
    Using connection As New SqlConnection("connection string here"),
          command As New SqlCommand(query, connection)
        connection.Open()

Dim table As New DataTable

Using reader = command.ExecuteReader(CommandBehavior.CloseConnection)
            table.Load(reader)
        End Using

Return table
    End Using
End Function[/CODE]
[/QUOTE]

Verification