Resolved Pass A Byte Array To A Sub

[zunebuggy65]

I am trying to pass a Byte array to a sub, but no matter how I do it, the sub is writing all zeros.

    Dim myBinArry(2000) As Byte

    'Code to fill myBinArry here.
    'Verified myBinArry(0) - myBinArry(1999) contain values.

    WriteBinaryFile(myFileName, myBinArry)

    Private Sub WriteBinaryFile(ByVal myFileName As String, ByVal myBinArry As Byte)
        Dim binWrite As BinaryWriter
        binWrite = New BinaryWriter(File.Open(myFileName, FileMode.Create))
        Using binWrite
            For t = 0 To Len(myBinArry) ' I know I should use Ubound and I will as soon as I get passing the Array to work
                binWrite.Write(myBinArry(t))
            Next
        End Using
        binWrite.Close()
    End Sub
  
    'Result: file is created but it writes only zeros.

Secondary, less important question. I use Relyze to view my binary files (decompiler). Can anyone recommend something better? It crashes with large files.

Thank you

 

[JohnH]

myBinArry As Byte

That is a single Byte, not a Byte() array.

 

[zunebuggy65]

I changed it to

myBinArry() As Byte

and it still writes zeros.

 

[zunebuggy65]

I also tried

myBinArry As Byte()

with the same result.

 

[JohnH]

Len(myBinArry)

What is that? Strings.Len? Should probably be myBinArry.Length - 1

 

[zunebuggy65]

Ahh, but

ByRef myBinArry As Byte()

did work. Thank you for your assistance in getting the answer.

 

[zunebuggy65]

I'm hoping my last solution in this thread is the correct one. If so, I will mark it resolved. It's strange. I did a search for Passing Byte Arrays to a Sub and the only good example I could find was to Dim the Array as Byte and to pass it without () or ByRef in the parameters calling the Sub. I had so many combinations to try. I knew I would stumble on it eventually.

 

[JohnH]

ByRef:

Specifies that an argument is passed in such a way that the called procedure can change the value of a variable underlying the argument in the calling code.

It has no use in this case.

 

[zunebuggy65]

Hmmm. It seems to work but I will look at it under the compiler.

I even considered converting my Array to a very long String representation of the Byte Array and passing that String because that always works, except I am dealing with very large binary files.

 

[zunebuggy65]

To answer your Len(myBinArry()) question, most might be at max 10,000 but could be as high as 35,979,265. That's the issue.

 

[zunebuggy65]

That one was a fluke. It did not work. Not sure what it did. Maybe I need to use a Function?